Arm backend: Add support for bandit linting tool#16827
Conversation
perheld
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16827
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 6f2cad2 with merge base e9a1937 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
Hi @SS-JIA this enable more lintrunning stuff for Arm folder but as it's in the global config files I assume we need a proper review :) |
SS-JIA
left a comment
SS-JIA
left a comment
There was a problem hiding this comment.
Should be ok since there are no changes to existing linters. Test failures do seem unrelated to me, but would be good to double check
| certifi # Imported by resolve_buck.py. | ||
| lintrunner==0.12.7 | ||
| lintrunner-adapters==0.12.6 | ||
| lintrunner-adapters==0.13.0 |
There was a problem hiding this comment.
this change is notable but should be okay as long as lintrunner passes
There was a problem hiding this comment.
Yeah, it needs to be bumped to have support for bandit. I created the PR with support and got it merged so they where kind enough to make a new release. :)
justinchuby/lintrunner-adapters#132
|
Just merged a fix for some Arm-backend tests rebasing to clean out those errors :) |
Add tooling for bandit to run with lintrunner. Signed-off-by: per.held@arm.com Change-Id: I76f6f9336e161ed04b7c062b0b437a23ba497f09
|
Cortex-m seems unrelated. Lintrunner job ran so Im quite confident this should work. |
3 participants
Add tooling for bandit to run with lintrunner.
Signed-off-by: per.held@arm.com
Change-Id: I76f6f9336e161ed04b7c062b0b437a23ba497f09
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai